Remove unnecessary buffer doubling and content copying.

Remove unnecessary buffer doubling and content copying.

[Lasse Reichstein, 2009-11-06 14:18:19]

Please review.
This reduces copying by buffer-growth in a certain test suite from 17Mb to 50Kb.

[Lasse Reichstein, 2009-11-06 15:31:51]

http://codereview.chromium.org/377006/diff/1/2
File src/objects.h (right):

http://codereview.chromium.org/377006/diff/1/2#newcode3927
Line 3927: inline bool IsTwoByte();
Woops, unrelated change that survived reversion. I'll remove these again.

http://codereview.chromium.org/377006/diff/1/3
File src/scanner.cc (right):

http://codereview.chromium.org/377006/diff/1/3#newcode66
Line 66: Max(kInitialCapacity,
This Max is not longer necessary (I started lower at some point).

[Christian Plesner Hansen, 2009-11-09 08:40:50]

Lgtm

http://codereview.chromium.org/377006/diff/1/3
File src/scanner.cc (right):

http://codereview.chromium.org/377006/diff/1/3#newcode386
Line 386: literal_buffer =
Please add a comment that explains what's going on here.

[Lasse Reichstein, 2009-11-09 11:46:53]

http://codereview.chromium.org/377006/diff/1/3
File src/scanner.cc (right):

http://codereview.chromium.org/377006/diff/1/3#newcode386
Line 386: literal_buffer =
Good thing you asked me to comment it. It makes more sense if rearranged a
little.
I've moved this code to StartLiteral() and the setting of next_.literal_buffer
to NULL to Next(). This avoids testing on each added character (the completely
empty literal, i.e., the empty string, doesn't occur often enough to make a
special case of it).
And I've added a comment.