Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Unified Diff: src/ia32/stub-cache-ia32.cc

Issue 377004: Fixed problem where popping a handle scope after calling an accessor (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ia32/stub-cache-ia32.cc
diff --git a/src/ia32/stub-cache-ia32.cc b/src/ia32/stub-cache-ia32.cc
index 3e5fc047949328ccfcdd26ef812d4e1b26e5213b..89745a00ca33363e34fc06ec640c66790b593f95 100644
--- a/src/ia32/stub-cache-ia32.cc
+++ b/src/ia32/stub-cache-ia32.cc
@@ -804,8 +804,9 @@ void StubCompiler::GenerateLoadCallback(JSObject* object,
ApiGetterEntryStub stub(callback_handle, &fun);
__ CallStub(&stub);
+ // We need to avoid using eax since that now holds the result.
Register tmp = other.is(eax) ? reg : other;
- __ PopHandleScope(tmp);
+ __ PopHandleScope(Vector<const Register>(&eax, 1), tmp);
__ LeaveInternalFrame();
__ ret(0);

Powered by Google App Engine
This is Rietveld 408576698