Issue 377004: Fixed problem where popping a handle scope after calling an accessor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 377004: Fixed problem where popping a handle scope after calling an accessor (Closed)

Created:
11 years, 1 month ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Visibility:
Public.

Description

Fixed problem where popping a handle scope after calling an accessor would clobber the register holding the result.

Patch Set 1 #

Total comments: 6

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -3 lines)			Patch
M	src/ia32/macro-assembler-ia32.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 chunk	+8 lines, -1 line	6 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-accessors.cc	View	1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM, if the popping is reversed. http://codereview.chromium.org/377004/diff/1/2 File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/377004/diff/1/2#newcode976 Line 976: void MacroAssembler::PopHandleScope(Vector<const ...

11 years, 1 month ago (2009-11-06 11:23:31 UTC) #2

Christian Plesner Hansen

11 years, 1 month ago (2009-11-06 11:33:07 UTC) #3

http://codereview.chromium.org/377004/diff/1/2
File src/ia32/macro-assembler-ia32.cc (right):

http://codereview.chromium.org/377004/diff/1/2#newcode976
Line 976: void MacroAssembler::PopHandleScope(Vector<const Register> saved,
Fixed

http://codereview.chromium.org/377004/diff/1/2#newcode987
Line 987: push(saved[i]);
Fixed

http://codereview.chromium.org/377004/diff/1/2#newcode990
Line 990: pop(saved[i]);
Whoops!  Fixed.

Expand Messages | Collapse Messages