Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 3769007: New Heap profiler: add dumping HeapNumbers and InternalFields to snapshot. (Closed)

Created:
10 years, 2 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

New Heap profiler: add dumping HeapNumbers and InternalFields to snapshot. HeapNumbers do consume memory, so it's worth dumping them. However, we don't dump their values, as they are not as self-descriptive as values of strings, and they will increase snapshot size. Storing heap numbers values can be added if we will feel a sufficient demand for that. InternalFields are used, e.g. for storing references to DOM nodes event handlers. Committed: http://code.google.com/p/v8/source/detail?r=5635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -46 lines) Patch
M include/v8-profiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/profile-generator.h View 9 chunks +14 lines, -4 lines 0 comments Download
M src/profile-generator.cc View 12 chunks +60 lines, -24 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 14 chunks +50 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
10 years, 2 months ago (2010-10-15 15:30:02 UTC) #1
Søren Thygesen Gjesse
10 years, 2 months ago (2010-10-18 07:38:39 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698