Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 3769002: Fix "No SCM found for url None" error that can occur after update... (Closed)

Created:
10 years, 2 months ago by jaysoffian
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Fix "No SCM found for url None" error that can occur after update This occurs when gclient compares the cached deps in .gclient_entries to the new DEPS and tries to construct an SCM for any cached entries which no longer exist. In this situation gclient doesn't account for the case where previous entries may have been ignored by setting their url to None via the custom_deps section in .gclient. Contributed by Jay Soffian. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62540

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M gclient.py View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
jaysoffian
This occurs when gclient compares the cached deps in .gclient_entries to the new DEPS and ...
10 years, 2 months ago (2010-10-13 21:31:12 UTC) #1
M-A Ruel
10 years, 2 months ago (2010-10-14 01:51:30 UTC) #2
I'll commit tomorrow morning.

http://codereview.chromium.org/3769002/diff/1/2
File gclient.py (right):

http://codereview.chromium.org/3769002/diff/1/2#newcode738
gclient.py:738: if prev_url is None:
I'll change it for "if not prev_url:"

Powered by Google App Engine
This is Rietveld 408576698