src/arm/code-stubs-arm.cc - Issue 3767016: Fix bug in comparison of two smis that differ by MIN_SMI on full compiler on ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/code-stubs-arm.cc

Issue 3767016: Fix bug in comparison of two smis that differ by MIN_SMI on full compiler on ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/code-stubs-arm.cc

===================================================================

--- src/arm/code-stubs-arm.cc (revision 5639)

+++ src/arm/code-stubs-arm.cc (working copy)

@@ -935,11 +935,8 @@

__ orr(r2, r1, r0);

__ tst(r2, Operand(kSmiTagMask));

__ b(ne, &not_two_smis);

- __ sub(r0, r1, r0, SetCC);

- __ b(vc, &smi_done);

- // Correct the sign in case of overflow.

- __ rsb(r0, r0, Operand(0, RelocInfo::NONE));

- __ bind(&smi_done);

+ __ mov(r1, Operand(r1, ASR, 1));

+ __ sub(r0, r1, Operand(r0, ASR, 1));

__ Ret();

__ bind(&not_two_smis);

} else if (FLAG_debug_code) {

« no previous file with comments | « no previous file | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »