Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3767016: Fix bug in comparison of two smis that differ by MIN_SMI on full compiler on ... (Closed)

Created:
10 years, 2 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Fix bug in comparison of two smis that differ by MIN_SMI on full compiler on all platforms. Committed: http://code.google.com/p/v8/source/detail?r=5643

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -10 lines) Patch
M src/arm/code-stubs-arm.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/int32-ops.js View 1 chunk +227 lines, -0 lines 0 comments Download
M test/mjsunit/smi-ops.js View 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
10 years, 2 months ago (2010-10-18 13:20:04 UTC) #1
fschneider
http://codereview.chromium.org/3767016/diff/1/4 File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/3767016/diff/1/4#newcode2126 src/x64/code-stubs-x64.cc:2126: __ not_(rdx); // Correct sign in case of overflow. ...
10 years, 2 months ago (2010-10-18 13:26:58 UTC) #2
fschneider
10 years, 2 months ago (2010-10-18 13:29:03 UTC) #3 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698