Issue 3764011: Link all global contexts into a weak list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3764011: Link all global contexts into a weak list. (Closed)

Created:
10 years, 2 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, marklam

CC:
v8-dev

Visibility:
Public.

Description

Link all global contexts into a weak list. Committed: http://code.google.com/p/v8/source/detail?r=5649

Patch Set 1 #

Total comments: 2

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+239 lines, -4 lines)			Patch
M	src/bootstrapper.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/contexts.h	View	2 chunks	+19 lines, -1 line	1 comment	Download
M	src/heap.h	View	6 chunks	+29 lines, -1 line	0 comments	Download
M	src/heap.cc	View	6 chunks	+50 lines, -1 line	0 comments	Download
M	src/mark-compact.cc	View	6 chunks	+31 lines, -0 lines	1 comment	Download
M	src/objects.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/objects-visiting.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/serialize.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View	2 chunks	+86 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/3764011/diff/1/3 File src/contexts.h (right): http://codereview.chromium.org/3764011/diff/1/3#newcode345 src/contexts.h:345: // GC support. Maybe extend the comment to ...

10 years, 2 months ago (2010-10-18 14:31:09 UTC) #2

marklam

10 years, 2 months ago (2010-10-19 00:57:19 UTC) #3

Drive by comment:

http://codereview.chromium.org/3764011/diff/1/6
File src/mark-compact.cc (right):

http://codereview.chromium.org/3764011/diff/1/6#newcode2277
src/mark-compact.cc:2277:
updating_visitor.VisitPointer(&Heap::global_contexts_list_);
For consistency, shouldn't this be made to call
Heap::global_contexts_list_address() like at line 1668 above?

Expand Messages | Collapse Messages