Issue 3764005: cashew: Service: set "in progress" flag before requesting usage update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3764005: cashew: Service: set "in progress" flag before requesting usage update (Closed)

Created:
10 years, 2 months ago by Vince Laviano

Modified:
9 years ago

Reviewers:
Jason Glasgow

CC:
chromium-os-reviews_chromium.org, Vince Laviano

Base URL:
ssh://git@gitrw.chromium.org:9222/cashew.git

Visibility:
Public.

Description

cashew: Service: set "in progress" flag before requesting usage update This CL fixes an inconsistency in the request_in_progress_ flag that triggers an assertion failure. Root cause: OnRequestComplete asserts that the request_in_progress_ flag is set. RequestUsageUpdate sets the flag *after* initiating an update via DataPlanProvider::RequestUsageUpdate. However, it's possible for the OnRequestComplete callback to be invoked from within this initial call, prior to the flag being set. Resolution: Set the flag first, then initiate the update. BUG=chromium-os:7687 TEST=None Change-Id: I302093d0ae51107aed350e590327e7a9f44a2ae0 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=23cc9cf

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/service.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages