Issue 3764004: Handle short read error correctly in vbutil_kernel.c

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3764004: Handle short read error correctly in vbutil_kernel.c (Closed)

Created:
10 years, 2 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://git.chromium.org/git/vboot_reference.git

Visibility:
Public.

Description

Handle short read error correctly in vbutil_kernel.c If you try to read a file that's all zeros, it tries to read a zero-length kernel blob, fails to do so (or suceeds with an empty result, depending on your point of view), and prints ERROR: Unable to read kernel blob from <file>: Success That's not very helpful. This change makes it say ERROR: No kernel blob found instead. Change-Id: I841ec6e288f47cd9b1f8e9ca1e6da0741ad20e9f BUG=none TEST=none Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2f6a71f

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -3 lines)			Patch
	M	utility/vbutil_kernel.c	View		5 chunks	+18 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages