Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 3763012: CPU Profiler: postpone moved functions registration until GC completes. (Closed)

Created:
10 years, 2 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

CPU Profiler: postpone moved functions registration until GC completes. An attempt to retrieve security context for a function may fail if the destination heap space is in an incomplete state. To fix this, we only record unknown functions discovered at GC object moves, and then register them after GC completes. BUG=crbug/59627 Committed: http://code.google.com/p/v8/source/detail?r=5667

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M src/cpu-profiler.h View 3 chunks +5 lines, -2 lines 0 comments Download
M src/cpu-profiler.cc View 3 chunks +21 lines, -23 lines 2 comments Download
M src/heap.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/log.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/log.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mark-compact.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mnaganov (inactive)
10 years, 2 months ago (2010-10-19 17:08:59 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/3763012/diff/1/2 File src/cpu-profiler.cc (right): http://codereview.chromium.org/3763012/diff/1/2#newcode443 src/cpu-profiler.cc:443: void CpuProfiler::RegisterMovedFunctions() { Register -> Process?
10 years, 2 months ago (2010-10-20 07:08:22 UTC) #2
mnaganov (inactive)
10 years, 2 months ago (2010-10-20 08:29:05 UTC) #3
http://codereview.chromium.org/3763012/diff/1/2
File src/cpu-profiler.cc (right):

http://codereview.chromium.org/3763012/diff/1/2#newcode443
src/cpu-profiler.cc:443: void CpuProfiler::RegisterMovedFunctions() {
On 2010/10/20 07:08:22, Søren Gjesse wrote:
> Register -> Process?

Done.

Powered by Google App Engine
This is Rietveld 408576698