Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: tools/memory_watcher/scripts/summary.pl

Issue 376003: Update summarizing script for memory dump results.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/memory_watcher/scripts/summary.pl
===================================================================
--- tools/memory_watcher/scripts/summary.pl (revision 31097)
+++ tools/memory_watcher/scripts/summary.pl (working copy)
@@ -33,10 +33,10 @@
if ($loc =~ m/v8::internal::Snapshot::Deserialize/) {
$location_blame = "v8 Snapshot Deserialize";
+ } elsif ($loc =~ m/RenderStyle::create/) {
+ $location_blame = "RenderStyle::create";
} elsif ($loc =~ m/v8::internal::OldSpace::SlowAllocateRaw/) {
$location_blame = "v8 OldSpace";
- } elsif ($loc =~ m/v8/) {
- $location_blame = "v8";
} elsif ($loc =~ m/sqlite/) {
$location_blame = "sqlite";
} elsif ($loc =~ m/ TransportDIB::Map/) {
@@ -115,15 +115,15 @@
$location_blame = "history publisher";
} else {
$location_blame = "unknown";
-# print "$location_blame: ($bytes) $loc\n";
}
# Surface large outliers in an "interesting" group.
- # When questioned about a specific group listed above, we
- # can just enter its name here, and get details.
+ my $interesting_group = "unknown";
+ my $interesting_size = 10000000; # Make this smaller as needed.
# TODO(jar): Add this as a pair of shell arguments.
- if ($bytes > 10000000 && $location_blame eq "unknown") {
- $location_blame = "\n" . $loc;
+ if ($bytes > $interesting_size && $location_blame eq $interesting_group) {
+ # Create a special group for the exact stack that contributed so much.
+ $location_blame = $loc;
}
$total_bytes += $bytes;
@@ -135,7 +135,7 @@
my @keys = sort { $leaks{$b} <=> $leaks{$a} }keys %leaks;
for ($i=0; $i<@keys; $i++) {
my $key = @keys[$i];
- printf "%11s\t%3.2f%%\t%s\n", comma_print($leaks{$key}), (100* $leaks{$key} / $total_bytes), $key;
+ printf "%11s\t(%3.2f%%)\t%s\n", comma_print($leaks{$key}), (100* $leaks{$key} / $total_bytes), $key;
$sum += $leaks{$key};
}
printf("TOTAL: %s\n", comma_print($sum));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698