Strtod fast-case that uses DiyFps and cached powers of ten.

Strtod fast-case that uses DiyFps and cached powers of ten.

Committed: http://code.google.com/p/v8/source/detail?r=5677

[William Hesse, 2010-10-20 14:52:19]

LGTM.

http://codereview.chromium.org/3760013/diff/1/6
File src/strtod.cc (right):

http://codereview.chromium.org/3760013/diff/1/6#newcode146
src/strtod.cc:146: // In almost all cases the number of read digits is maximal.
What does that mean?  What is maximal?

http://codereview.chromium.org/3760013/diff/1/6#newcode276
src/strtod.cc:276: int error = (remaining_decimals == 0? 0: kDenominator / 2);
Put spaces on both sides of the ? and :.

[Florian Loitsch, 2010-10-20 15:12:37]

http://codereview.chromium.org/3760013/diff/1/6
File src/strtod.cc (right):

http://codereview.chromium.org/3760013/diff/1/6#newcode146
src/strtod.cc:146: // In almost all cases the number of read digits is maximal.
On 2010/10/20 14:52:19, William Hesse wrote:
> What does that mean?  What is maximal?

Updated comment.
It means: it reads as many digits as fit into a uint64.
However there are some corner cases where it would have been possible to read
one additional digit.

http://codereview.chromium.org/3760013/diff/1/6#newcode276
src/strtod.cc:276: int error = (remaining_decimals == 0? 0: kDenominator / 2);
On 2010/10/20 14:52:19, William Hesse wrote:
> Put spaces on both sides of the ? and :.

Done.