Issue 3755010: Add the chroot creator to the default set of allowed groups (with override flag).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3755010: Add the chroot creator to the default set of allowed groups (with override flag). (Closed)

Created:
10 years, 2 months ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, Markus (顧孟勤)

CC:
chromium-reviews

Visibility:
Public.

Description

Add the chroot creator to the default set of allowed groups (with override flag). This fixes a buildbot issue where chroots can't be used without sudo (because there is no 'admin' group, and chrome-bot only belongs to the 'chrome-bot' group). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62790

Patch Set 1 #

Total comments: 1

Patch Set 2 : review cleanup #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
	M	build/install-chroot.sh	View	1	3 chunks	+15 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Markus (顧孟勤)

10 years, 2 months ago (2010-10-15 20:45:55 UTC) #2

LGTM

http://codereview.chromium.org/3755010/diff/1/2
File build/install-chroot.sh (right):

http://codereview.chromium.org/3755010/diff/1/2#newcode25
build/install-chroot.sh:25: g)
Maybe rewrite this more concisely as:

[ -n "${OPTARG}" ] &&
chroot_groups="${chroot_groups}${chroot_groups:+,}${OPTARG}"

Expand Messages | Collapse Messages