Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issue 3750002: Add timeout for safebrowsing test. (Closed)

Created:
10 years, 2 months ago by lzheng
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Nicolas Sylvain, pam+watch_chromium.org
Visibility:
Public.

Description

Add timeout for safebrowsing test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62567

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M scripts/master/factory/chromium_factory.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
lzheng
I started a local buildbot using this change, although I can force local build, but ...
10 years, 2 months ago (2010-10-13 18:51:09 UTC) #1
M-A Ruel
I thought you wanted to do that only on Windows, you can look for self._target_platform ...
10 years, 2 months ago (2010-10-13 18:56:09 UTC) #2
lzheng
I believe it would be easier to keep track by using just one value across ...
10 years, 2 months ago (2010-10-14 16:31:49 UTC) #3
M-A Ruel
10 years, 2 months ago (2010-10-14 16:39:04 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698