Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 3748007: Do not return the constant singleton float -0.0 from UnaryOpStub, because it ... (Closed)

Created:
10 years, 2 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Do not return the constant singleton float -0.0 from UnaryOpStub, because it may be overwritten, on X64 platform. Committed: http://code.google.com/p/v8/source/detail?r=5631

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -13 lines 0 comments Download
M test/mjsunit/smi-negative-zero.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
William Hesse
10 years, 2 months ago (2010-10-15 14:37:34 UTC) #1
Kevin Millikin (Chromium)
10 years, 2 months ago (2010-10-15 14:50:30 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698