Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 3745005: Fix bug in cache handling of lastIndex on global regexps. (Closed)

Created:
10 years, 2 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Fix bug in cache handling of lastIndex on global regexps.

Patch Set 1 #

Patch Set 2 : Added regression test. #

Patch Set 3 : Remove leftover crud from test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M src/regexp.js View 1 chunk +2 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-58740.js View 2 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
10 years, 2 months ago (2010-10-13 17:18:15 UTC) #1
Erik Corry
LGTM, but only with a regression test.
10 years, 2 months ago (2010-10-13 21:28:21 UTC) #2
Lasse Reichstein
10 years, 2 months ago (2010-10-14 08:24:13 UTC) #3
Regression test added.

Powered by Google App Engine
This is Rietveld 408576698