Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: chrome/browser/chromeos/login/network_screen_browsertest.cc

Issue 3744009: chromium-os:5494 Networks with identical names not handled properly. (Closed)
Patch Set: Rebase from trunk. Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/network_screen.cc ('k') | chrome/browser/chromeos/network_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/network_screen_browsertest.cc
diff --git a/chrome/browser/chromeos/login/network_screen_browsertest.cc b/chrome/browser/chromeos/login/network_screen_browsertest.cc
index a2a4b3495dc51806f0182f5cf567cd1d011d8e4f..bce1a6fa53d871652ea69c1857393e83fced5269 100644
--- a/chrome/browser/chromeos/login/network_screen_browsertest.cc
+++ b/chrome/browser/chromeos/login/network_screen_browsertest.cc
@@ -180,9 +180,9 @@ IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Wifi) {
.WillOnce((Return(false)));
EXPECT_CALL(*mock_network_library_, wifi_connecting())
.WillOnce((Return(true)));
- std::string wifi_name = "wifi";
- EXPECT_CALL(*mock_network_library_, wifi_name())
- .WillOnce(ReturnRef(wifi_name));
+ WifiNetwork wifi;
+ EXPECT_CALL(*mock_network_library_, wifi_network())
+ .WillOnce(ReturnRef(wifi));
network_screen->NetworkChanged(mock_network_library_);
EXPECT_FALSE(network_view->IsContinueEnabled());
@@ -221,9 +221,9 @@ IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Cellular) {
.WillOnce((Return(false)));
EXPECT_CALL(*mock_network_library_, cellular_connecting())
.WillOnce((Return(true)));
- std::string cellular_name = "3G";
- EXPECT_CALL(*mock_network_library_, cellular_name())
- .WillOnce(ReturnRef(cellular_name));
+ CellularNetwork cellular;
+ EXPECT_CALL(*mock_network_library_, cellular_network())
+ .WillOnce(ReturnRef(cellular));
network_screen->NetworkChanged(mock_network_library_);
EXPECT_FALSE(network_view->IsContinueEnabled());
@@ -260,9 +260,9 @@ IN_PROC_BROWSER_TEST_F(NetworkScreenTest, Timeout) {
.WillOnce((Return(false)));
EXPECT_CALL(*mock_network_library_, wifi_connecting())
.WillOnce((Return(true)));
- std::string wifi_name = "wifi";
- EXPECT_CALL(*mock_network_library_, wifi_name())
- .WillOnce(ReturnRef(wifi_name));
+ WifiNetwork wifi;
+ EXPECT_CALL(*mock_network_library_, wifi_network())
+ .WillOnce(ReturnRef(wifi));
EXPECT_CALL(*mock_network_library_, Connected())
.WillOnce(Return(false));
« no previous file with comments | « chrome/browser/chromeos/login/network_screen.cc ('k') | chrome/browser/chromeos/network_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698