Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 3744008: Work around Windows bug. Use different constants. (Closed)

Created:
10 years, 2 months ago by Florian Loitsch
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Work around Windows bug. Use different constants. Windows' strtod doesn't correctly read 3e-324 a the lowest denormal, but returns 0.0 instead. Using 4e-324 is still the same value and works. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=5624

Patch Set 1 #

Patch Set 2 : Work around Windows bug. Use different constants.... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/cctest/test-strtod.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Loitsch
10 years, 2 months ago (2010-10-14 15:02:10 UTC) #1
William Hesse
10 years, 2 months ago (2010-10-14 15:15:08 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698