Rename FileUtilProxy::Create to EnsureFileExists

Rename FileUtilProxy::Create to EnsureFileExists

per follow-up discussion on http://codereview.chromium.org/3717001/show

Rename FileUtilProxy::Create to EnsureFileExists to make it clear that
it doesn't open the file (or doesn't leave a file handle opened).

Also fixes CreatePlatformFile to set |created| correctly when
PLATFORM_FILE_CREATE flag is given (I think this is the correct
behavior).

BUG=none
TEST=FileSystemOperationTest.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62683

[brettw, 2010-10-14 16:29:26]

LGTM, thanks for the follow-up.

http://codereview.chromium.org/3743004/diff/2001/3002
File base/file_util_proxy.h (right):

http://codereview.chromium.org/3743004/diff/2001/3002#newcode70
base/file_util_proxy.h:70: // of the callback is set true in the case.
Can you explicitly mention that that created flag will be false if the file
already exists, and what also happens if the file doesn't exist but couldn't be
created (like maybe the directory is invalid).

[kinuko, 2010-10-15 00:14:19]

On 2010/10/14 16:29:26, brettw wrote:
> LGTM, thanks for the follow-up.
> 
> http://codereview.chromium.org/3743004/diff/2001/3002
> File base/file_util_proxy.h (right):
> 
> http://codereview.chromium.org/3743004/diff/2001/3002#newcode70
> base/file_util_proxy.h:70: // of the callback is set true in the case.
> Can you explicitly mention that that created flag will be false if the file
> already exists, and what also happens if the file doesn't exist but couldn't
be
> created (like maybe the directory is invalid).

Fixed the comment to explicitly mention each case.  Will be submitting...