Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: gpu/command_buffer/service/program_manager.h

Issue 3743001: FBTF: Fix more ctor/dtors found by clang plugin. (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: Rebase to pick up mac fix on ToT Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/id_manager.cc ('k') | gpu/command_buffer/service/program_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/program_manager.h
diff --git a/gpu/command_buffer/service/program_manager.h b/gpu/command_buffer/service/program_manager.h
index a10ba61c2392281532398b1eaa049ff339fa32b1..7fb6fa4267ba60b63ba4ffe6ad993632f0f98af2 100644
--- a/gpu/command_buffer/service/program_manager.h
+++ b/gpu/command_buffer/service/program_manager.h
@@ -32,11 +32,9 @@ class ProgramManager {
static const int kMaxAttachedShaders = 2;
struct UniformInfo {
- UniformInfo(GLsizei _size, GLenum _type, const std::string& _name)
- : size(_size),
- type(_type),
- name(_name) {
- }
+ UniformInfo(GLsizei _size, GLenum _type, const std::string& _name);
+ ~UniformInfo();
+
bool IsSampler() const {
return type == GL_SAMPLER_2D || type == GL_SAMPLER_CUBE;
}
@@ -66,12 +64,7 @@ class ProgramManager {
typedef std::vector<VertexAttribInfo> AttribInfoVector;
typedef std::vector<int> SamplerIndices;
- explicit ProgramInfo(GLuint service_id)
- : max_attrib_name_length_(0),
- max_uniform_name_length_(0),
- service_id_(service_id),
- valid_(false) {
- }
+ explicit ProgramInfo(GLuint service_id);
GLuint service_id() const {
return service_id_;
@@ -154,7 +147,7 @@ class ProgramManager {
friend class base::RefCounted<ProgramInfo>;
friend class ProgramManager;
- ~ProgramInfo() { }
+ ~ProgramInfo();
void MarkAsDeleted() {
service_id_ = 0;
@@ -195,7 +188,7 @@ class ProgramManager {
std::string log_info_;
};
- ProgramManager() { }
+ ProgramManager();
~ProgramManager();
// Must call before destruction.
« no previous file with comments | « gpu/command_buffer/service/id_manager.cc ('k') | gpu/command_buffer/service/program_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698