Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1984)

Unified Diff: gpu/command_buffer/service/program_manager.cc

Issue 3743001: FBTF: Fix more ctor/dtors found by clang plugin. (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: Rebase to pick up mac fix on ToT Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/program_manager.h ('k') | gpu/command_buffer/service/renderbuffer_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/program_manager.cc
diff --git a/gpu/command_buffer/service/program_manager.cc b/gpu/command_buffer/service/program_manager.cc
index 3460019267e63927301a85b01656b585886b6955..c19806a5478131e2b407af73e9d074c96a0101f9 100644
--- a/gpu/command_buffer/service/program_manager.cc
+++ b/gpu/command_buffer/service/program_manager.cc
@@ -27,12 +27,30 @@ static int ShaderTypeToIndex(GLenum shader_type) {
}
}
+
+ProgramManager::ProgramInfo::UniformInfo::UniformInfo(GLsizei _size,
+ GLenum _type,
+ const std::string& _name)
+ : size(_size),
+ type(_type),
+ name(_name) {
+}
+
+ProgramManager::ProgramInfo::UniformInfo::~UniformInfo() {}
+
bool ProgramManager::IsInvalidPrefix(const char* name, size_t length) {
static const char kInvalidPrefix[] = { 'g', 'l', '_' };
return (length >= sizeof(kInvalidPrefix) &&
memcmp(name, kInvalidPrefix, sizeof(kInvalidPrefix)) == 0);
}
+ProgramManager::ProgramInfo::ProgramInfo(GLuint service_id)
+ : max_attrib_name_length_(0),
+ max_uniform_name_length_(0),
+ service_id_(service_id),
+ valid_(false) {
+}
+
void ProgramManager::ProgramInfo::Reset() {
valid_ = false;
max_uniform_name_length_ = 0;
@@ -320,6 +338,10 @@ bool ProgramManager::ProgramInfo::CanLink() const {
return true;
}
+ProgramManager::ProgramInfo::~ProgramInfo() {}
+
+ProgramManager::ProgramManager() {}
+
ProgramManager::~ProgramManager() {
DCHECK(program_infos_.empty());
}
« no previous file with comments | « gpu/command_buffer/service/program_manager.h ('k') | gpu/command_buffer/service/renderbuffer_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698