Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: gpu/command_buffer/service/framebuffer_manager.h

Issue 3743001: FBTF: Fix more ctor/dtors found by clang plugin. (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: Rebase to pick up mac fix on ToT Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/common_decoder.cc ('k') | gpu/command_buffer/service/framebuffer_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/framebuffer_manager.h
diff --git a/gpu/command_buffer/service/framebuffer_manager.h b/gpu/command_buffer/service/framebuffer_manager.h
index 175da42e04ab3bc452f10bd71c45c66664a687d8..79ebb2f53180118084466522216f2cba77f9a877 100644
--- a/gpu/command_buffer/service/framebuffer_manager.h
+++ b/gpu/command_buffer/service/framebuffer_manager.h
@@ -24,9 +24,7 @@ class FramebufferManager {
public:
typedef scoped_refptr<FramebufferInfo> Ref;
- explicit FramebufferInfo(GLuint service_id)
- : service_id_(service_id) {
- }
+ explicit FramebufferInfo(GLuint service_id);
GLuint service_id() const {
return service_id_;
@@ -49,7 +47,7 @@ class FramebufferManager {
friend class FramebufferManager;
friend class base::RefCounted<FramebufferInfo>;
- ~FramebufferInfo() { }
+ ~FramebufferInfo();
void MarkAsDeleted() {
service_id_ = 0;
@@ -65,7 +63,7 @@ class FramebufferManager {
AttachmentToRenderbufferMap renderbuffers_;
};
- FramebufferManager() { }
+ FramebufferManager();
~FramebufferManager();
// Must call before destruction.
« no previous file with comments | « gpu/command_buffer/service/common_decoder.cc ('k') | gpu/command_buffer/service/framebuffer_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698