Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2510)

Unified Diff: chrome/browser/tab_contents/tab_contents_view.h

Issue 3743001: FBTF: Fix more ctor/dtors found by clang plugin. (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: Rebase to pick up mac fix on ToT Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/tab_contents_view.h
diff --git a/chrome/browser/tab_contents/tab_contents_view.h b/chrome/browser/tab_contents/tab_contents_view.h
index c2e7cc3e720a82c05b0aa74b3ac7b46f64529fc0..45507811108fd7c86d684d92ff57120fabd7d569 100644
--- a/chrome/browser/tab_contents/tab_contents_view.h
+++ b/chrome/browser/tab_contents/tab_contents_view.h
@@ -31,7 +31,7 @@ class TabContents;
class TabContentsView : public RenderViewHostDelegate::View {
public:
explicit TabContentsView(TabContents* tab_contents);
- virtual ~TabContentsView() {}
+ virtual ~TabContentsView();
// Creates the appropriate type of TabContentsView for the current system.
// The return value is a new heap allocated view with ownership passing to
@@ -142,9 +142,7 @@ class TabContentsView : public RenderViewHostDelegate::View {
// If we try to close the tab while a drag is in progress, we crash. These
// methods allow the tab contents to determine if a drag is in progress and
// postpone the tab closing.
- virtual bool IsDoingDrag() const {
- return false;
- }
+ virtual bool IsDoingDrag() const;
virtual void CancelDragAndCloseTab() {}
// If we close the tab while a UI control is in an event-tracking
@@ -152,17 +150,13 @@ class TabContentsView : public RenderViewHostDelegate::View {
// TabContents::Close() calls IsEventTracking(), and if it returns
// true CloseTabAfterEventTracking() is called and the close is not
// completed.
- virtual bool IsEventTracking() const {
- return false;
- }
+ virtual bool IsEventTracking() const;
virtual void CloseTabAfterEventTracking() {}
- virtual bool ShouldDrawDropShadow() {
- return false;
- }
+ virtual bool ShouldDrawDropShadow();
protected:
- TabContentsView() {} // Abstract interface.
+ TabContentsView(); // Abstract interface.
// Internal functions used to support the CreateNewWidget() method. If a
// platform requires plugging into widget creation at a lower level then a
« no previous file with comments | « chrome/browser/tab_contents/render_view_host_delegate_helper.cc ('k') | chrome/browser/tab_contents/tab_contents_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698