Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2076)

Unified Diff: chrome/browser/shell_dialogs.h

Issue 3743001: FBTF: Fix more ctor/dtors found by clang plugin. (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: Rebase to pick up mac fix on ToT Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/default_apps.cc ('k') | chrome/browser/shell_dialogs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/shell_dialogs.h
diff --git a/chrome/browser/shell_dialogs.h b/chrome/browser/shell_dialogs.h
index eac3f5e9d888697fb334d76435908bbacd6dc368..9b080f9c36019ce860134b8321c37d6ac6e5df8c 100644
--- a/chrome/browser/shell_dialogs.h
+++ b/chrome/browser/shell_dialogs.h
@@ -92,6 +92,9 @@ class SelectFileDialog
// |include_all_files| specifies whether there will be a filter added for all
// files (i.e. *.*).
struct FileTypeInfo {
+ FileTypeInfo();
+ ~FileTypeInfo();
+
std::vector<std::vector<FilePath::StringType> > extensions;
std::vector<string16> extension_description_overrides;
bool include_all_files;
@@ -134,8 +137,8 @@ class SelectFileDialog
protected:
friend class base::RefCountedThreadSafe<SelectFileDialog>;
-
- virtual ~SelectFileDialog() {}
+ SelectFileDialog();
+ virtual ~SelectFileDialog();
};
// Shows a dialog box for selecting a font.
@@ -191,8 +194,8 @@ class SelectFontDialog
protected:
friend class base::RefCountedThreadSafe<SelectFontDialog>;
-
- virtual ~SelectFontDialog() {}
+ SelectFontDialog();
+ virtual ~SelectFontDialog();
};
#endif // CHROME_BROWSER_SHELL_DIALOGS_H_
« no previous file with comments | « chrome/browser/extensions/default_apps.cc ('k') | chrome/browser/shell_dialogs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698