Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 374023: First cut at Exit Fullscreen bubble on Linux. (Closed)

Created:
11 years, 1 month ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, Evan Stade
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

First cut at Exit Fullscreen bubble on Linux. It shows and disappears after 3 seconds. There is no way to bring it back. The following remain to be done: - Rounding the bottom corners (with a radius of 8, ActAsRoundedWindow looks ugly) and make it transparent. - Slide in/out animation. - Implement the logic in the Windows version for when to show or hide the bubble. It's pretty complicated and I haven't decided whether to port it or to try to share it. BUG=8405 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31461

Patch Set 1 #

Patch Set 2 : comments #

Patch Set 3 : remove header #

Total comments: 4

Patch Set 4 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -0 lines) Patch
M chrome/browser/gtk/browser_window_gtk.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 1 2 3 3 chunks +4 lines, -0 lines 0 comments Download
A chrome/browser/gtk/fullscreen_exit_bubble_gtk.h View 1 2 3 1 chunk +46 lines, -0 lines 0 comments Download
A chrome/browser/gtk/fullscreen_exit_bubble_gtk.cc View 1 2 3 1 chunk +106 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tony
11 years, 1 month ago (2009-11-07 01:13:16 UTC) #1
Evan Stade
crbug.com/24950 has a patch attached which makes "actual" rounded corners, which I abandoned because for ...
11 years, 1 month ago (2009-11-07 01:56:57 UTC) #2
tony
http://codereview.chromium.org/374023/diff/4001/5003 File chrome/browser/gtk/fullscreen_exit_bubble_gtk.cc (right): http://codereview.chromium.org/374023/diff/4001/5003#newcode26 Line 26: GtkFloatingContainer* container) : container_(container) { On 2009/11/07 01:56:57, ...
11 years, 1 month ago (2009-11-09 18:19:13 UTC) #3
Evan Stade
11 years, 1 month ago (2009-11-09 18:21:21 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698