Issue 3739001: Temporarily clear noexec flag on /var if set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3739001: Temporarily clear noexec flag on /var if set (Closed)

Created:
10 years, 2 months ago by Paul Stewart

Modified:
9 years, 7 months ago

Reviewers:
Daniel Kurtz

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://gitrw.chromium.org/crosutils.git

Visibility:
Public.

Description

Temporarily clear noexec flag on /var if set The "emerge" process sometimes copies files to /var/tmp and then run it. Recent changes to images set the "noexec" flag on /var, thus preventing such activities. Temporarily clear this flag from within cros_package_to_live. BUG=none TEST=Manually set noexec on /var and run cros_package_to_live Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e45157f

Patch Set 1 #

Total comments: 1

Patch Set 2 : Small nits and debug message #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	bin/cros_package_to_live	View	1	2 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Daniel Kurtz

10 years, 2 months ago (2010-10-12 20:40:21 UTC) #2

1 small nit, no need for round-trip.
LGTM

http://codereview.chromium.org/3739001/diff/1/2
File bin/cros_package_to_live (right):

http://codereview.chromium.org/3739001/diff/1/2#newcode74
bin/cros_package_to_live:74: root_mount_type=$REMOTE_OUT
You placed {} around other vars, so:
root_mount_type=${REMOTE_OUT}

Expand Messages | Collapse Messages