Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: gclient.py

Issue 3737001: Fix a bug in gclient recurse for git-svn users. Make gclient_utils.CheckCall more versatile. (Closed)
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gclient_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient.py
diff --git a/gclient.py b/gclient.py
index 9cf30c76cb6fb4bb659f71f153549452bca6433e..989a1c418d5ec309204a778131ed68ebe8ed0dcc 100644
--- a/gclient.py
+++ b/gclient.py
@@ -888,9 +888,12 @@ def CMDrecurse(parser, args):
if scm_set and scm not in scm_set:
continue
cwd = os.path.normpath(os.path.join(root, path))
- env['GCLIENT_SCM'] = scm
- env['GCLIENT_URL'] = url
- subprocess.Popen(args, cwd=cwd, env=env).communicate()
+ if scm:
+ env['GCLIENT_SCM'] = scm
+ if url:
+ env['GCLIENT_URL'] = url
+ gclient_utils.Popen(args, cwd=cwd, env=env).communicate()
+ return 0
@attr('usage', '[url] [safesync url]')
« no previous file with comments | « no previous file | gclient_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698