Adding traces to a test when it fails in the hope of determining at least rul...

chrome/browser/views/find_bar_host_browsertest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/keyboard_codes.h"
 #include "base/message_loop.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_window.h"
 #include "chrome/browser/find_bar_controller.h"
 #include "chrome/browser/find_notification_details.h"
@@ skipping 25 matching lines @@
 const bool kIgnoreCase = false;
 const bool kCaseSensitive = true;
 
 class FindInPageControllerTest : public InProcessBrowserTest {
  public:
   FindInPageControllerTest() {
     EnableDOMAutomation();
   }
 
  protected:
-  void GetFindBarWindowInfo(gfx::Point* position, bool* fully_visible) {
+  bool GetFindBarWindowInfo(gfx::Point* position, bool* fully_visible) {
     FindBarTesting* find_bar =
         browser()->GetFindBarController()->find_bar()->GetFindBarTesting();
-    find_bar->GetFindBarWindowInfo(position, fully_visible);
+    return find_bar->GetFindBarWindowInfo(position, fully_visible);
   }
 };
 
 // This test loads a page with frames and starts FindInPage requests.
 IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindInPageFrames) {
   HTTPTestServer* server = StartHTTPServer();
 
   // First we navigate to our frames page.
   GURL url = server->TestServerPageW(kFramePage);
   ui_test_utils::NavigateToURL(browser(), url);
@@ skipping 407 matching lines @@
   ui_test_utils::NavigateToURL(browser(), url);
 
   // Open the Find window with animations disabled.
   FindBarHost::disable_animations_during_testing_ = true;
   browser()->ShowFindBar();
 
   gfx::Point position;
   bool fully_visible = false;
 
   // Make sure it is open.
-  GetFindBarWindowInfo(&position, &fully_visible);
+  EXPECT_TRUE(GetFindBarWindowInfo(&position, &fully_visible));
   EXPECT_TRUE(fully_visible);
 
   // Reload the tab and make sure Find window doesn't go away.
   browser()->Reload();
 
-  GetFindBarWindowInfo(&position, &fully_visible);
+  EXPECT_TRUE(GetFindBarWindowInfo(&position, &fully_visible));
   EXPECT_TRUE(fully_visible);
 
   // Navigate and make sure the Find window goes away.
   ui_test_utils::NavigateToURL(browser(), url2);
 
-  GetFindBarWindowInfo(&position, &fully_visible);
+  EXPECT_TRUE(GetFindBarWindowInfo(&position, &fully_visible));
   EXPECT_FALSE(fully_visible);
 }
 
 // Make sure Find box disappears when History/Downloads page is opened, and
 // when a New Tab is opened.
 IN_PROC_BROWSER_TEST_F(FindInPageControllerTest,
                        FindDisappearOnNewTabAndHistory) {
   HTTPTestServer* server = StartHTTPServer();
 
   // First we navigate to our special focus tracking page.
   GURL url = server->TestServerPageW(kSimplePage);
   ui_test_utils::NavigateToURL(browser(), url);
 
   // Open the Find window with animations disabled.
   FindBarHost::disable_animations_during_testing_ = true;
   browser()->ShowFindBar();
 
   gfx::Point position;
   bool fully_visible = false;
 
   // Make sure it is open.
-  GetFindBarWindowInfo(&position, &fully_visible);
+  EXPECT_TRUE(GetFindBarWindowInfo(&position, &fully_visible));
   EXPECT_TRUE(fully_visible);
 
   // Open another tab (tab B).
   browser()->NewTab();
   ui_test_utils::NavigateToURL(browser(), url);
 
   // Make sure Find box is closed.
-  GetFindBarWindowInfo(&position, &fully_visible);
+  EXPECT_TRUE(GetFindBarWindowInfo(&position, &fully_visible));
   EXPECT_FALSE(fully_visible);
 
   // Close tab B.
   browser()->CloseTab();
 
   // Make sure Find window appears again.
-  GetFindBarWindowInfo(&position, &fully_visible);
+  EXPECT_TRUE(GetFindBarWindowInfo(&position, &fully_visible));
   EXPECT_TRUE(fully_visible);
 
   browser()->ShowHistoryTab();
 
   // Make sure Find box is closed.
-  GetFindBarWindowInfo(&position, &fully_visible);
+  EXPECT_TRUE(GetFindBarWindowInfo(&position, &fully_visible));
   EXPECT_FALSE(fully_visible);
 }
 
 // Make sure Find box moves out of the way if it is obscuring the active match.
 // Flaky, see http://crbug.com/16447.
 IN_PROC_BROWSER_TEST_F(FindInPageControllerTest,
                        FLAKY_FindMovesWhenObscuring) {
   HTTPTestServer* server = StartHTTPServer();
 
   GURL url = server->TestServerPageW(kMoveIfOver);
   ui_test_utils::NavigateToURL(browser(), url);
 
   // Open the Find window with animations disabled.
   FindBarHost::disable_animations_during_testing_ = true;
   browser()->ShowFindBar();
 
   gfx::Point start_position;
   gfx::Point position;
   bool fully_visible = false;
 
   // Make sure it is open.
-  GetFindBarWindowInfo(&start_position, &fully_visible);
+  EXPECT_TRUE(GetFindBarWindowInfo(&start_position, &fully_visible));
   EXPECT_TRUE(fully_visible);
 
   // Search for 'dream' which the Find box is obscuring.
   int ordinal = 0;
   TabContents* tab = browser()->GetSelectedTabContents();
   EXPECT_EQ(1, ui_test_utils::FindInPage(tab, L"dream",
                                          kFwd, kIgnoreCase, &ordinal));
   EXPECT_EQ(1, ordinal);
 
   // Make sure Find box has moved.
-  GetFindBarWindowInfo(&position, &fully_visible);
+  EXPECT_TRUE(GetFindBarWindowInfo(&position, &fully_visible));
+  EXPECT_TRUE(fully_visible);
   EXPECT_EQ(start_position.y(), position.y());
+  if (start_position.x() == position.x()) {
+    // Failure case. Try to gather more data.
+    std::string debug_msg = "Position check failed once. ";
+    if (!GetFindBarWindowInfo(&position, &fully_visible)) {
+      debug_msg += "Get failed. ";
+    } else {
+      if (start_position.x() == position.x())
+        debug_msg += "Still the same. ";
+      else
+        debug_msg += "They now differ. ";
+    }
+    // Force the failure.
+    EXPECT_STREQ("", debug_msg.c_str());
+  }
   EXPECT_NE(start_position.x(), position.x());
-  EXPECT_TRUE(fully_visible);
 
   // Search for 'Too much' which the Find box is not obscuring.
   EXPECT_EQ(1, ui_test_utils::FindInPage(tab, L"Too much",
                                          kFwd, kIgnoreCase, &ordinal));
   EXPECT_EQ(1, ordinal);
 
   // Make sure Find box has moved back to its original location.
-  GetFindBarWindowInfo(&position, &fully_visible);
+  EXPECT_TRUE(GetFindBarWindowInfo(&position, &fully_visible));
+  EXPECT_TRUE(fully_visible);
   EXPECT_EQ(start_position, position);
-  EXPECT_TRUE(fully_visible);
 }
 
 // Make sure F3 in a new tab works if Find has previous string to search for.
 IN_PROC_BROWSER_TEST_F(FindInPageControllerTest,
                        FindNextInNewTabUsesPrepopulate) {
   HTTPTestServer* server = StartHTTPServer();
 
   // First we navigate to any page.
   GURL url = server->TestServerPageW(kSimplePage);
   ui_test_utils::NavigateToURL(browser(), url);
@@ skipping 79 matching lines @@
   // backspace, but that's been proven flaky in the past, so we go straight to
   // tab_contents.
   TabContents* tab_contents = browser()->GetSelectedTabContents();
   // Stop the (non-existing) find operation, and clear the selection (which
   // signals the UI is still active).
   tab_contents->StopFinding(true);
   // Make sure the Find UI flag hasn't been cleared, it must be so that the UI
   // still responds to browser window resizing.
   ASSERT_TRUE(tab_contents->find_ui_active());
 }