Issue 372059: Revert 3245 and 3246 because they cause valgrind failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 372059: Revert 3245 and 3246 because they cause valgrind failures. (Closed)

Created:
11 years, 1 month ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Revert 3245 and 3246 because they cause valgrind failures. TBR=lrn Committed: http://code.google.com/p/v8/source/detail?r=3254

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -43 lines)			Patch
	M	src/scanner.h	View		5 chunks	+12 lines, -31 lines	0 comments	Download
	M	src/scanner.cc	View		5 chunks	+14 lines, -12 lines	0 comments	Download

Total messages: 2 (0 generated)

Lasse Reichstein

11 years, 1 month ago (2009-11-10 09:33:00 UTC) #2

Looks bad to me :P
But is probably good.
I'll fix the valgrind complaint and reapply.