Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: base/lazy_instance.cc

Issue 372057: Isolate tests by running AtExit callbacks between them. (Closed)
Patch Set: fix Linux hang Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/lazy_instance.h ('k') | base/lazy_instance_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/lazy_instance.h" 5 #include "base/lazy_instance.h"
6 6
7 #include "base/at_exit.h" 7 #include "base/at_exit.h"
8 #include "base/atomicops.h" 8 #include "base/atomicops.h"
9 #include "base/dynamic_annotations.h" 9 #include "base/dynamic_annotations.h"
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/platform_thread.h" 11 #include "base/platform_thread.h"
12 12
13 namespace base { 13 namespace base {
14 14
15 void LazyInstanceHelper::EnsureInstance(void* instance, 15 void LazyInstanceHelper::EnsureInstance(void* instance,
16 void (*ctor)(void*), 16 void (*ctor)(void*),
17 void (*dtor)(void*)) { 17 void (*dtor)(void*)) {
18 // Try to create the instance, if we're the first, will go from EMPTY 18 // Try to create the instance, if we're the first, will go from EMPTY
19 // to CREATING, otherwise we've already been beaten here. 19 // to CREATING, otherwise we've already been beaten here.
20 if (base::subtle::Acquire_CompareAndSwap( 20 if (base::subtle::Acquire_CompareAndSwap(
21 &state_, STATE_EMPTY, STATE_CREATING) == STATE_EMPTY) { 21 &state_, STATE_EMPTY, STATE_CREATING) == STATE_EMPTY) {
22 // Created the instance in the space provided by |instance|. 22 // Created the instance in the space provided by |instance|.
23 ctor(instance); 23 ctor(instance);
24 24
25 // See the comment to the corresponding HAPPENS_AFTER in Pointer(). 25 // See the comment to the corresponding HAPPENS_AFTER in Pointer().
26 ANNOTATE_HAPPENS_BEFORE(&state_); 26 ANNOTATE_HAPPENS_BEFORE(&state_);
27 27
28 // Instance is created, go from CREATING to CREATED. 28 // Instance is created, go from CREATING to CREATED.
29 base::subtle::Release_Store(&state_, STATE_CREATED); 29 base::subtle::Release_Store(&state_, STATE_CREATED);
30 // Register the destructor callback with AtExitManager. 30
31 // Allow reusing the LazyInstance (reset it to the initial state). This
32 // makes possible calling all AtExit callbacks between tests. Assumes that
33 // no other threads execute when AtExit callbacks are processed.
34 base::AtExitManager::RegisterCallback(&LazyInstanceHelper::ResetState,
35 this);
36
37 // Make sure that the lazily instantiated object will get destroyed at exit.
31 base::AtExitManager::RegisterCallback(dtor, instance); 38 base::AtExitManager::RegisterCallback(dtor, instance);
32 } else { 39 } else {
33 // It's either in the process of being created, or already created. Spin. 40 // It's either in the process of being created, or already created. Spin.
34 while (base::subtle::NoBarrier_Load(&state_) != STATE_CREATED) 41 while (base::subtle::NoBarrier_Load(&state_) != STATE_CREATED)
35 PlatformThread::YieldCurrentThread(); 42 PlatformThread::YieldCurrentThread();
36 } 43 }
37 } 44 }
38 45
46 // static
47 void LazyInstanceHelper::ResetState(void* helper) {
48 reinterpret_cast<LazyInstanceHelper*>(helper)->state_ = STATE_EMPTY;
49 }
50
39 } // namespace base 51 } // namespace base
OLDNEW
« no previous file with comments | « base/lazy_instance.h ('k') | base/lazy_instance_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698