Fix various problems with inline autocomplete and URLs that change length dur...

Fix various problems with inline autocomplete and URLs that change length during fixup:
* URLs with http auth info, which gets stripped
* URLs with IDN hosts
* URLs with escaped values that get unescaped

In cases like these, we'd inline autocomplete from the wrong locations, highlight the wrong portions of the URL as matches, and sometimes DCHECK() in debug mode.

The fix is to track how fixup affects the offsets into the URL we care about.  Plumbing this required an enormous number of additions :(

There is also a fix here to the URL Fixer Upper, which was obviously modified at some point in the past to use the Parsed components, but without updating the comments or some of the functionality to match.  Since this isn't supposed to "fix up" things that aren't simple typos, I removed some code to "fix" bogus ports, which was causing bizarre effects when typing HTTP auth URLs ("http://foo:bar" would be fixed to "http://foo" and then matched for inline autocompletion, which was clearly wrong).  This is tested incidentally by one of the new History URL Provider tests (which is how I discovered it).

BUG=4010
TEST=Covered by unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31352

[Peter Kasting, 2009-11-06 09:35:38]

This really should be reviewed by Brett, but since I'm trying to get it in by
code freeze and he seems to be on vacation, I'm also roping in Scott as an
alternate.  Sorry, this probably won't be any more fun to review than it was to
write :(

[sky, 2009-11-06 19:22:24]

LGTM

Brett, be sure and give this a once over when you're back.

http://codereview.chromium.org/372017/diff/1/14
File base/i18n/icu_string_conversions.cc (right):

http://codereview.chromium.org/372017/diff/1/14#newcode163
Line 163: const char* codepage_name,
nit: spacing is off.

http://codereview.chromium.org/372017/diff/1/14#newcode178
Line 178: // Converts a string of the given codepage into UTF-16.
Do you really need the description here and in the header? Especially when the
header is more complete.

http://codereview.chromium.org/372017/diff/1/12
File base/utf_string_conversions.cc (right):

http://codereview.chromium.org/372017/diff/1/12#newcode87
Line 87: // Appends a UTF-8 character to the given 8-bit string.
Document what the return type is for these methods were you're changing to
return count.

http://codereview.chromium.org/372017/diff/1/12#newcode164
Line 164: output_offset = DEST_STRING::npos;
I had to stare at this for a while. This code is subtle enough I think it's
worth a comment, both here and in why you do + 1. in the else case.

http://codereview.chromium.org/372017/diff/1/26
File chrome/browser/net/url_fixer_upper.cc (right):

http://codereview.chromium.org/372017/diff/1/26#newcode275
Line 275: // We don't fix up the port at the moment.
How about a comment as to why we don't?

http://codereview.chromium.org/372017/diff/1/6
File net/base/net_util.cc (right):

http://codereview.chromium.org/372017/diff/1/6#newcode685
Line 685: // We'll break out of the loop below.
Seems less error prone to just have a break here too.

[Peter Kasting, 2009-11-07 00:07:37]

http://codereview.chromium.org/372017/diff/1/26
File chrome/browser/net/url_fixer_upper.cc (right):

http://codereview.chromium.org/372017/diff/1/26#newcode275
Line 275: // We don't fix up the port at the moment.
On 2009/11/06 19:22:24, sky wrote:
> How about a comment as to why we don't?

It's not obvious what to say, and this matches the multiple places above and
below that we have this same comment :/

http://codereview.chromium.org/372017/diff/1/6
File net/base/net_util.cc (right):

http://codereview.chromium.org/372017/diff/1/6#newcode685
Line 685: // We'll break out of the loop below.
This got a little clearer when I removed the comment and added some whitespace.