Issue 3719002: Add support for multi-line status messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3719002: Add support for multi-line status messages. (Closed)

Created:
10 years, 2 months ago by DaleCurtis

Modified:
9 years, 7 months ago

Reviewers:
ericli

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

Add support for multi-line status messages. Many of our Autotest test cases return multi-line status messages upon failure. Due to the regular expression used by Autotest these lines cause an "AttributeError: 'NoneType' object has no attribute 'groups'" exception to be thrown. By modifying the regular expression to allow '.' to match '\n' these errors are avoided. I've added a new unit test, test_parse_line_handles_embedded_new_lines(), to check for these types of messages. Change-Id: I0b3f4d90caf2cfc81724b928f6bea90eec6c38b0 BUG=7611 TEST=Ran unit tests. Ran in production system over the weekend. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7b2c643

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	tko/parsers/version_0.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	tko/parsers/version_0_unittest.py	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ericli

10 years, 2 months ago (2010-10-11 22:09:55 UTC) #2

LGTM.

On 2010/10/11 22:02:43, dalec wrote:
> Will be submitted upstream after review.
> 
> PTAL

Expand Messages | Collapse Messages