webkit/fileapi/file_system_operation.cc - Issue 3717001: Make sure we close the file_handle when we create (but not open) a new file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/fileapi/file_system_operation.cc

Issue 3717001: Make sure we close the file_handle when we create (but not open) a new file (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: changed the flag name Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/fileapi/file_system_operation.cc

diff --git a/webkit/fileapi/file_system_operation.cc b/webkit/fileapi/file_system_operation.cc

index 29690b90a18344b65211c8aa00226ff58a574a28..e15de4ccb0a26bba658007887c4b559b00497b85 100644

--- a/webkit/fileapi/file_system_operation.cc

+++ b/webkit/fileapi/file_system_operation.cc

@@ -36,7 +36,7 @@ void FileSystemOperation::CreateFile(const FilePath& path,

pending_operation_ = kOperationCreateFile;

#endif

- base::FileUtilProxy::CreateOrOpen(

+ base::FileUtilProxy::Create(

proxy_, path, base::PLATFORM_FILE_CREATE | base::PLATFORM_FILE_READ,

callback_factory_.NewCallback(

exclusive ? &FileSystemOperation::DidCreateFileExclusive

@@ -145,7 +145,7 @@ void FileSystemOperation::Write(

file_writer_delegate_.reset(new FileWriterDelegate(this, offset));

blob_request_.reset(new URLRequest(blob_url, file_writer_delegate_.get()));

blob_request_->set_context(url_request_context);

- base::FileUtilProxy::CreateOrOpen(

+ base::FileUtilProxy::Create(

proxy_,

path,

base::PLATFORM_FILE_OPEN | base::PLATFORM_FILE_WRITE |

« base/file_util_proxy.h ('K') | « base/file_util_proxy.cc ('k') | no next file » | no next file with comments »