Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 3712003: AU: Verify source rootfs/kernel hashes before applying delta. (Closed)

Created:
10 years, 2 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, petkov, adlr
Visibility:
Public.

Description

AU: Verify source rootfs/kernel hashes before applying delta. New style full updates will not send the old rootfs hash so no check takes place. BUG=7562 TEST=unit tests, gmerged on device and tested with good/bad source partition Change-Id: I65b28bf57110e4d87472d4aea59121878cde24b0 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=698d041

Patch Set 1 #

Patch Set 2 : fix copyright #

Patch Set 3 : unit test for RawHashOfFile #

Total comments: 2

Patch Set 4 : rebase, fixes and cleanup #

Patch Set 5 : verify source partitions only for new updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -28 lines) Patch
M action_processor.h View 1 chunk +1 line, -0 lines 0 comments Download
M delta_diff_generator.cc View 1 2 3 2 chunks +3 lines, -6 lines 0 comments Download
M delta_performer.h View 1 2 3 4 chunks +22 lines, -1 line 0 comments Download
M delta_performer.cc View 1 2 3 4 2 chunks +23 lines, -0 lines 0 comments Download
M delta_performer_unittest.cc View 1 2 3 2 chunks +9 lines, -2 lines 0 comments Download
M download_action.cc View 1 2 3 4 chunks +15 lines, -6 lines 0 comments Download
M filesystem_copier_action.h View 1 2 3 7 chunks +35 lines, -9 lines 0 comments Download
M filesystem_copier_action.cc View 1 2 3 4 chunks +37 lines, -2 lines 0 comments Download
M filesystem_copier_action_unittest.cc View 1 2 3 2 chunks +34 lines, -2 lines 0 comments Download
M install_plan.h View 2 chunks +4 lines, -0 lines 0 comments Download
M omaha_hash_calculator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M omaha_hash_calculator.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M omaha_hash_calculator_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
petkov
10 years, 2 months ago (2010-10-12 19:17:07 UTC) #1
adlr
LGTM w/ nit http://codereview.chromium.org/3712003/diff/4001/5004 File delta_performer.h (right): http://codereview.chromium.org/3712003/diff/4001/5004#newcode99 delta_performer.h:99: void set_current_kernel_hash(std::vector<char>& hash) { hm, I ...
10 years, 2 months ago (2010-10-12 19:38:07 UTC) #2
petkov
Fixed to work with the server-side change: http://codereview.chromium.org/3748001/show This CL needs to go in after ...
10 years, 2 months ago (2010-10-13 15:01:40 UTC) #3
adlr
10 years, 2 months ago (2010-10-13 17:38:35 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698