Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 371070: Fixed bug in while-loops that caused an assertion to fail. ... (Closed)

Created:
11 years, 1 month ago by fschneider
Modified:
9 years, 6 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Fixed bug in while-loops that caused an assertion to fail. We forgot resetting true-/false-label to NULL after evaluating the condition expression in dowhile- and while-loops. This change fixes this. This causes an assertion to fail in VisitIfStatement whenever there is an if-statement after a while-loop before. e.g. like in: var i=0, j=0; while(j<5) { j++; } if (i ==0 ) { j++; }

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M src/compiler.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M src/fast-codegen.cc View 2 chunks +4 lines, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
Small fix that re-activates while-loops and dowhile-loops and fixes the debug assertion failure in test/mjsunit/array-concat.js
11 years, 1 month ago (2009-11-09 16:10:35 UTC) #1
Lasse Reichstein
LGTM http://codereview.chromium.org/371070/diff/1/3 File src/fast-codegen.cc (right): http://codereview.chromium.org/371070/diff/1/3#newcode319 Line 319: true_label_ = &body; We should probably have ...
11 years, 1 month ago (2009-11-10 09:35:34 UTC) #2
fschneider
11 years, 1 month ago (2009-11-10 09:57:18 UTC) #3
http://codereview.chromium.org/371070/diff/1/3
File src/fast-codegen.cc (right):

http://codereview.chromium.org/371070/diff/1/3#newcode319
Line 319: true_label_ = &body;
On 2009/11/10 09:35:34, Lasse Reichstein wrote:
> We should probably have some scoped object that set and unset/reset both
labels.
> This seems like unnecessary book-keeping.

Good point.

Powered by Google App Engine
This is Rietveld 408576698