Fix small memory leak in new serialization code.

src/bootstrapper.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 79 matching lines @@
   FixedArray* cache_;
   DISALLOW_COPY_AND_ASSIGN(SourceCodeCache);
 };
 
 static SourceCodeCache natives_cache(Script::TYPE_NATIVE);
 static SourceCodeCache extensions_cache(Script::TYPE_EXTENSION);
 // This is for delete, not delete[].
 static List<char*>* delete_these_non_arrays_on_tear_down = NULL;
 
 
+NativesExternalStringResource::NativesExternalStringResource(const char* source)
+    : data_(source), length_(strlen(source)) {
+  if (delete_these_non_arrays_on_tear_down == NULL) {
+    delete_these_non_arrays_on_tear_down = new List<char*>(2);
+  }
+  // The resources are small objects and we only make a fixed number of
+  // them, but let's clean them up on exit for neatness.
+  delete_these_non_arrays_on_tear_down->
+      Add(reinterpret_cast<char*>(this));
+}
+
+
 Handle<String> Bootstrapper::NativesSourceLookup(int index) {
   ASSERT(0 <= index && index < Natives::GetBuiltinsCount());
   if (Heap::natives_source_cache()->get(index)->IsUndefined()) {
     if (!Snapshot::IsEnabled() || FLAG_new_snapshot) {
-      if (delete_these_non_arrays_on_tear_down == NULL) {
-        delete_these_non_arrays_on_tear_down = new List<char*>(2);
-      }
       // We can use external strings for the natives.
       NativesExternalStringResource* resource =
           new NativesExternalStringResource(
               Natives::GetScriptSource(index).start());
-      // The resources are small objects and we only make a fixed number of
-      // them, but lets clean them up on exit for neatness.
-      delete_these_non_arrays_on_tear_down->
-          Add(reinterpret_cast<char*>(resource));
       Handle<String> source_code =
           Factory::NewExternalStringFromAscii(resource);
       Heap::natives_source_cache()->set(index, *source_code);
     } else {
       // Old snapshot code can't cope with external strings at all.
       Handle<String> source_code =
         Factory::NewStringFromAscii(Natives::GetScriptSource(index));
       Heap::natives_source_cache()->set(index, *source_code);
     }
   }
@@ skipping 1508 matching lines @@
 }
 
 
 // Restore statics that are thread local.
 char* Genesis::RestoreState(char* from) {
   current_ = *reinterpret_cast<Genesis**>(from);
   return from + sizeof(current_);
 }
 
 } }  // namespace v8::internal