Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 371067: Add parentheses to prevent precedence errors.... (Closed)

Created:
11 years, 1 month ago by Jan de Mooij
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Add parentheses to prevent precedence errors. GCC 4.4 catches it: "suggest parentheses around '&&' within '||'"

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/jsregexp.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Jan de Mooij
11 years, 1 month ago (2009-11-09 12:49:26 UTC) #1
Erik Corry
11 years, 1 month ago (2009-11-09 13:10:12 UTC) #2
LGTM.  I will commit this.

Powered by Google App Engine
This is Rietveld 408576698