Issue 371062: [GTTF] Make DirectoryWatcher tests faster by about 15 seconds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 371062: [GTTF] Make DirectoryWatcher tests faster by about 15 seconds. (Closed)

Created:
11 years, 1 month ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

[GTTF] Make DirectoryWatcher tests faster by about 15 seconds. TEST=Covered by base_unittests. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31451

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	base/directory_watcher_unittest.cc	View		8 chunks	+10 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm, we'll see if it increases flakiness. http://codereview.chromium.org/371062/diff/1/2 File base/directory_watcher_unittest.cc (right): http://codereview.chromium.org/371062/diff/1/2#newcode25 Line 25: const ...

11 years, 1 month ago (2009-11-09 18:33:19 UTC) #2

Paweł Hajdan Jr.

11 years, 1 month ago (2009-11-09 18:36:41 UTC) #3

On 2009/11/09 18:33:19, Marc-Antoine Ruel wrote:
> http://codereview.chromium.org/371062/diff/1/2#newcode25
> Line 25: const int kWaitForEventTime = 500;
> I'm just afraid it'll fail on slow VMs. That's the reason for this slow wait
> time.

No problems with that. For events that should happen, this test waits with no
timeout. This kWaitForEventTime is for events that should not happen (as the
comment indicates), so there's no way that it can introduce new flaky failures.
It might not catch some unexpected notifications, but I think the risk is
minimal.

Expand Messages | Collapse Messages