chrome/browser/cocoa/bug_report_window_controller_unittest.mm - Issue 371057: Fix NSString conversions to treat a null NSString as a string of length 0, in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/bug_report_window_controller_unittest.mm

Issue 371057: Fix NSString conversions to treat a null NSString as a string of length 0, in... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/cocoa/bug_report_window_controller_unittest.mm

===================================================================

--- chrome/browser/cocoa/bug_report_window_controller_unittest.mm (revision 31117)

+++ chrome/browser/cocoa/bug_report_window_controller_unittest.mm (working copy)

@@ -54,9 +54,10 @@

initWithTabContents:NULL

profile:profile_.get()];

- // Make sure that no page title or URL are recorded.

- EXPECT_TRUE([[controller pageURL] isEqualToString:@""]);

- EXPECT_TRUE([[controller pageTitle] isEqualToString:@""]);

+ // Make sure that no page title or URL are recorded. Note that IB reports

+ // empty textfields as NULL values.

+ EXPECT_FALSE([controller pageURL]);

+ EXPECT_FALSE([controller pageTitle]);

// When we call "report bug" with empty tab contents, only menu options

// that don't refer to a specific page should be available, and the send

« no previous file with comments | « chrome/browser/cocoa/bug_report_window_controller.mm ('k') | no next file » | no next file with comments »