Fix NSString conversions to treat a null NSString as a string of length 0, in...

chrome/browser/cocoa/bug_report_window_controller.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/bug_report_window_controller.h"
 
 #include "app/l10n_util_mac.h"
 #include "base/mac_util.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/bug_report_util.h"
@@ skipping 15 matching lines @@
 @synthesize disableScreenshot = disableScreenshot_;
 @synthesize bugTypeList = bugTypeList_;
 
 - (id)initWithTabContents:(TabContents*)currentTab
                   profile:(Profile*)profile {
   NSString* nibpath = [mac_util::MainAppBundle() pathForResource:@"ReportBug"
                                                           ofType:@"nib"];
   if ((self = [super initWithWindowNibPath:nibpath owner:self])) {
     currentTab_ = currentTab;
     profile_ = profile;
-    [self setBugDescription:@""];
 
     if (currentTab_ != NULL) {
       // Get data from current tab, if one exists. This dialog could be called
       // from the main menu with no tab contents, so currentTab_ is not
       // guaranteed to be non-NULL.
       // TODO(mirandac): This dialog should be a tab-modal sheet if a browser
       // window exists.
       [self setSendScreenshot:YES];
       [self setDisableScreenshot:NO];
       bugTypeList_ = [[NSArray alloc] initWithObjects:
@@ skipping 15 matching lines @@
       // If no current tab exists, create a menu without the "broken page"
       // options, with page URL and title empty, and screenshot disabled.
       [self setSendScreenshot:NO];
       [self setDisableScreenshot:YES];
       bugTypeList_ = [[NSArray alloc] initWithObjects:
           l10n_util::GetNSStringWithFixup(IDS_BUGREPORT_CHROME_MISBEHAVES),
           l10n_util::GetNSStringWithFixup(IDS_BUGREPORT_SOMETHING_MISSING),
           l10n_util::GetNSStringWithFixup(IDS_BUGREPORT_BROWSER_CRASH),
           l10n_util::GetNSStringWithFixup(IDS_BUGREPORT_OTHER_PROBLEM),
           nil];
-      // Because "Report Bug" is being called with no browser open in this
-      // case, make URL and title empty.
-      [self setPageURL:@""];
-      [self setPageTitle:@""];
     }
   }
   return self;
 }
 
 - (void)dealloc {
   [pageURL_ release];
   [pageTitle_ release];
   [bugDescription_ release];
   [bugTypeList_ release];
@@ skipping 16 matching lines @@
   [NSApp runModalForWindow:bugReportWindow];
 }
 
 - (IBAction)sendReport:(id)sender {
   if ([self isPhishingReport]) {
     BugReportUtil::ReportPhishing(currentTab_,
         pageURL_ ? base::SysNSStringToUTF8(pageURL_) : "");
   } else {
     BugReportUtil::SendReport(
         profile_,
-        pageTitle_ ? base::SysNSStringToUTF8(pageTitle_) : "",
+        base::SysNSStringToUTF8(pageTitle_),
         bugType_,
-        pageURL_ ? base::SysNSStringToUTF8(pageURL_) : "",
-        bugDescription_ ? base::SysNSStringToUTF8(bugDescription_) : "",
+        base::SysNSStringToUTF8(pageURL_),
+        base::SysNSStringToUTF8(bugDescription_),
         sendScreenshot_ && !pngData_.empty() ?
             reinterpret_cast<const char *>(&(pngData_[0])) : NULL,
         pngData_.size());
   }
   [self closeDialog];
 }
 
 - (IBAction)cancel:(id)sender {
   [self closeDialog];
 }
@@ skipping 37 matching lines @@
   NSSet* paths = [super keyPathsForValuesAffectingValueForKey:key];
   if ([key isEqualToString:@"isPhishingReport"]) {
     paths = [paths setByAddingObject:@"bugType"];
   }
   return paths;
 }
 
 @end