Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6807)

Unified Diff: chrome/test/sync/engine/mock_server_connection.h

Issue 371029: Remove unique naming. (Closed)
Patch Set: Ready and about to go in! Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/test/sync/engine/mock_server_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/sync/engine/mock_server_connection.h
diff --git a/chrome/test/sync/engine/mock_server_connection.h b/chrome/test/sync/engine/mock_server_connection.h
old mode 100644
new mode 100755
index f4a110c80a339120e9fd0f14986cbe617233c5f8..e8fa9749a74a74b5493e78ed6e21946fba37baf8
--- a/chrome/test/sync/engine/mock_server_connection.h
+++ b/chrome/test/sync/engine/mock_server_connection.h
@@ -13,6 +13,7 @@
#include "chrome/browser/sync/engine/net/server_connection_manager.h"
#include "chrome/browser/sync/protocol/sync.pb.h"
#include "chrome/browser/sync/syncable/directory_manager.h"
+#include "chrome/browser/sync/util/closure.h"
using std::string;
using std::vector;
@@ -27,10 +28,6 @@ struct HttpResponse;
class MockConnectionManager : public browser_sync::ServerConnectionManager {
public:
- // A callback function type. These can be set to be called when server
- // activity would normally take place. This aids simulation of race
- // conditions.
- typedef bool (*TestCallbackFunction)(syncable::Directory* dir);
class MidCommitObserver {
public:
virtual void Observe() = 0;
@@ -49,7 +46,7 @@ class MockConnectionManager : public browser_sync::ServerConnectionManager {
virtual bool IsUserAuthenticated();
// Control of commit response.
- void SetMidCommitCallbackFunction(TestCallbackFunction callback);
+ void SetMidCommitCallback(Closure* callback);
void SetMidCommitObserver(MidCommitObserver* observer);
// Set this if you want commit to perform commit time rename. Will request
@@ -209,7 +206,7 @@ class MockConnectionManager : public browser_sync::ServerConnectionManager {
// The updates we'll return to the next request.
sync_pb::GetUpdatesResponse updates_;
- TestCallbackFunction mid_commit_callback_function_;
+ Closure* mid_commit_callback_;
MidCommitObserver* mid_commit_observer_;
// The AUTHENTICATE response we'll return for auth requests.
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/test/sync/engine/mock_server_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698