Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: chrome/browser/sync/engine/syncer_util.h

Issue 371029: Remove unique naming. (Closed)
Patch Set: Ready and about to go in! Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/engine/syncer_unittest.cc ('k') | chrome/browser/sync/engine/syncer_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/syncer_util.h
diff --git a/chrome/browser/sync/engine/syncer_util.h b/chrome/browser/sync/engine/syncer_util.h
old mode 100644
new mode 100755
index cf9d9c77a46eec3db8686d6c4190c6be7a1243ee..9f38873368e6be0198e0770d1caf7cfc01598dab
--- a/chrome/browser/sync/engine/syncer_util.h
+++ b/chrome/browser/sync/engine/syncer_util.h
@@ -26,12 +26,6 @@ class SyncEntity;
class SyncerUtil {
public:
- // TODO(ncarter): Remove unique-in-parent title support and name conflicts.
- static syncable::Id GetNameConflictingItemId(
- syncable::BaseTransaction* trans,
- const syncable::Id& parent_id,
- const PathString& server_name);
-
static void ChangeEntryIDAndUpdateChildren(
syncable::WriteTransaction* trans,
syncable::MutableEntry* entry,
@@ -56,16 +50,12 @@ class SyncerUtil {
syncable::MutableEntry* const entry,
ConflictResolver* resolver);
- static UpdateAttemptResponse AttemptToUpdateEntryWithoutMerge(
- syncable::WriteTransaction* const trans,
- syncable::MutableEntry* const entry,
- syncable::Id* const conflicting_id);
// Pass in name to avoid redundant UTF8 conversion.
static void UpdateServerFieldsFromUpdate(
syncable::MutableEntry* local_entry,
const SyncEntity& server_entry,
- const syncable::SyncName& name);
+ const PathString& name);
static void ApplyExtendedAttributes(
syncable::MutableEntry* local_entry,
@@ -186,6 +176,7 @@ inline bool ClientAndServerTimeMatch(int64 client_time, int64 server_time) {
// The sync server uses Java Times (ms since 1970)
// and the client uses FILETIMEs (ns since 1601) so we need to convert
// between the timescales.
+// TODO(sync): Fix this. No need to use two timescales.
inline int64 ServerTimeToClientTime(int64 server_time) {
return server_time * GG_LONGLONG(10000) + GG_LONGLONG(116444736000000000);
}
« no previous file with comments | « chrome/browser/sync/engine/syncer_unittest.cc ('k') | chrome/browser/sync/engine/syncer_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698