Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: chrome/browser/sync/syncable/syncable_columns.h

Issue 371029: Remove unique naming. (Closed)
Patch Set: Ready and about to go in! Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_SYNCABLE_SYNCABLE_COLUMNS_H_ 5 #ifndef CHROME_BROWSER_SYNC_SYNCABLE_SYNCABLE_COLUMNS_H_
6 #define CHROME_BROWSER_SYNC_SYNCABLE_SYNCABLE_COLUMNS_H_ 6 #define CHROME_BROWSER_SYNC_SYNCABLE_SYNCABLE_COLUMNS_H_
7 7
8 #include "chrome/browser/sync/syncable/syncable.h" 8 #include "chrome/browser/sync/syncable/syncable.h"
9 #include "chrome/browser/sync/syncable/syncable_changes_version.h" 9 #include "chrome/browser/sync/syncable/syncable_changes_version.h"
10 10
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 {"is_unsynced", "bit default 0"}, 43 {"is_unsynced", "bit default 0"},
44 {"is_unapplied_update", "bit default 0"}, 44 {"is_unapplied_update", "bit default 0"},
45 {"is_del", "bit default 0"}, 45 {"is_del", "bit default 0"},
46 {"is_dir", "bit default 0"}, 46 {"is_dir", "bit default 0"},
47 {"is_bookmark_object", "bit default 0"}, 47 {"is_bookmark_object", "bit default 0"},
48 {"server_is_dir", "bit default 0"}, 48 {"server_is_dir", "bit default 0"},
49 {"server_is_del", "bit default 0"}, 49 {"server_is_del", "bit default 0"},
50 {"server_is_bookmark_object", "bit default 0"}, 50 {"server_is_bookmark_object", "bit default 0"},
51 ////////////////////////////////////// 51 //////////////////////////////////////
52 // Strings 52 // Strings
53 {"name", "varchar(255) COLLATE PATHNAME"},
54 {"unsanitized_name", "varchar(255) COLLATE PATHNAME"},
55 {"non_unique_name", "varchar"}, 53 {"non_unique_name", "varchar"},
56 {"server_name", "varchar(255) COLLATE PATHNAME"}, 54 {"server_non_unique_name", "varchar(255) COLLATE PATHNAME"},
57 {"server_non_unique_name", "varchar"},
58 {"bookmark_url", "varchar"}, 55 {"bookmark_url", "varchar"},
59 {"server_bookmark_url", "varchar"}, 56 {"server_bookmark_url", "varchar"},
60 {"singleton_tag", "varchar"}, 57 {"singleton_tag", "varchar"},
61 ////////////////////////////////////// 58 //////////////////////////////////////
62 // Blobs. 59 // Blobs.
63 {"bookmark_favicon", "blob"}, 60 {"bookmark_favicon", "blob"},
64 {"server_bookmark_favicon", "blob"}, 61 {"server_bookmark_favicon", "blob"},
65 }; 62 };
66 63
67 // At least enforce that there are equal number of column names and fields. 64 // At least enforce that there are equal number of column names and fields.
68 COMPILE_ASSERT(arraysize(g_metas_columns) >= FIELD_COUNT, missing_column_name); 65 COMPILE_ASSERT(arraysize(g_metas_columns) >= FIELD_COUNT, missing_column_name);
69 COMPILE_ASSERT(arraysize(g_metas_columns) <= FIELD_COUNT, extra_column_names); 66 COMPILE_ASSERT(arraysize(g_metas_columns) <= FIELD_COUNT, extra_column_names);
70 67
71 static inline const char* ColumnName(int field) { 68 static inline const char* ColumnName(int field) {
72 DCHECK(field < BEGIN_TEMPS); 69 DCHECK(field < BEGIN_TEMPS);
73 return g_metas_columns[field].name; 70 return g_metas_columns[field].name;
74 } 71 }
75 72
76 } // namespace syncable 73 } // namespace syncable
77 74
78 #endif // CHROME_BROWSER_SYNC_SYNCABLE_SYNCABLE_COLUMNS_H_ 75 #endif // CHROME_BROWSER_SYNC_SYNCABLE_SYNCABLE_COLUMNS_H_
OLDNEW
« no previous file with comments | « chrome/browser/sync/syncable/syncable.cc ('k') | chrome/browser/sync/syncable/syncable_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698