Remove unique naming.

chrome/browser/sync/engine/syncer_proto_util_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/syncer_proto_util.h"
 
 #include "base/basictypes.h"
 #include "chrome/browser/sync/engine/syncproto.h"
 #include "chrome/browser/sync/syncable/blob.h"
 #include "chrome/browser/sync/syncable/syncable.h"
@@ skipping 57 matching lines @@
   EXPECT_TRUE(SyncerProtoUtil::ProtoBytesEqualsBlob(message2_copy,
                                                     test_blob2));
 }
 
 // Tests NameFromSyncEntity and NameFromCommitEntryResponse when only the name
 // field is provided.
 TEST(SyncerProtoUtil, NameExtractionOneName) {
   SyncEntity one_name_entity;
   CommitResponse_EntryResponse one_name_response;
 
-  PathString one_name_string(PSTR("Eggheadednesses"));
-  one_name_entity.set_name("Eggheadednesses");
-  one_name_response.set_name("Eggheadednesses");
+  const std::string one_name_string("Eggheadednesses");
+  one_name_entity.set_name(one_name_string);
+  one_name_response.set_name(one_name_string);
 
-  SyncName name_a = SyncerProtoUtil::NameFromSyncEntity(one_name_entity);
-  EXPECT_EQ(one_name_string, name_a.value());
-  EXPECT_EQ(one_name_string, name_a.non_unique_value());
+  const std::string name_a =
+      SyncerProtoUtil::NameFromSyncEntity(one_name_entity);
+  EXPECT_EQ(one_name_string, name_a);
 
-  SyncName name_b =
+  const std::string name_b =
       SyncerProtoUtil::NameFromCommitEntryResponse(one_name_response);
-  EXPECT_EQ(one_name_string, name_b.value());
-  EXPECT_EQ(one_name_string, name_b.non_unique_value());
+  EXPECT_EQ(one_name_string, name_b);
+  EXPECT_TRUE(name_a == name_b);
+}
 
+TEST(SyncerProtoUtil, NameExtractionOneUniqueName) {
+  SyncEntity one_name_entity;
+  CommitResponse_EntryResponse one_name_response;
+
+  const std::string one_name_string("Eggheadednesses");
+
+  one_name_entity.set_non_unique_name(one_name_string);
+  one_name_response.set_non_unique_name(one_name_string);
+
+  const std::string name_a =
+      SyncerProtoUtil::NameFromSyncEntity(one_name_entity);
+  EXPECT_EQ(one_name_string, name_a);
+
+  const std::string name_b =
+      SyncerProtoUtil::NameFromCommitEntryResponse(one_name_response);
+  EXPECT_EQ(one_name_string, name_b);
   EXPECT_TRUE(name_a == name_b);
 }
 
 // Tests NameFromSyncEntity and NameFromCommitEntryResponse when both the name
 // field and the non_unique_name fields are provided.
+// Should prioritize non_unique_name.
 TEST(SyncerProtoUtil, NameExtractionTwoNames) {
   SyncEntity two_name_entity;
   CommitResponse_EntryResponse two_name_response;
 
-  PathString two_name_string_unique(PSTR("Oxyphenbutazone"));
-  two_name_entity.set_name("Oxyphenbutazone");
-  two_name_response.set_name("Oxyphenbutazone");
-  PathString two_name_string(PSTR("Neuroanatomists"));
-  two_name_entity.set_non_unique_name("Neuroanatomists");
-  two_name_response.set_non_unique_name("Neuroanatomists");
+  const std::string neuro("Neuroanatomists");
+  const std::string oxyphen("Oxyphenbutazone");
 
-  SyncName name_a = SyncerProtoUtil::NameFromSyncEntity(two_name_entity);
-  EXPECT_EQ(two_name_string_unique, name_a.value());
-  EXPECT_EQ(two_name_string, name_a.non_unique_value());
+  two_name_entity.set_name(oxyphen);
+  two_name_entity.set_non_unique_name(neuro);
 
-  SyncName name_b =
+  two_name_response.set_name(oxyphen);
+  two_name_response.set_non_unique_name(neuro);
+
+  const std::string name_a =
+      SyncerProtoUtil::NameFromSyncEntity(two_name_entity);
+  EXPECT_EQ(neuro, name_a);
+
+  const std::string name_b =
       SyncerProtoUtil::NameFromCommitEntryResponse(two_name_response);
-  EXPECT_EQ(two_name_string_unique, name_b.value());
-  EXPECT_EQ(two_name_string, name_b.non_unique_value());
+  EXPECT_EQ(neuro, name_b);
 
   EXPECT_TRUE(name_a == name_b);
 }
 
 }  // namespace browser_sync