Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: chrome/browser/sync/engine/get_commit_ids_command.h

Issue 371029: Remove unique naming. (Closed)
Patch Set: Ready and about to go in! Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_ENGINE_GET_COMMIT_IDS_COMMAND_H_ 5 #ifndef CHROME_BROWSER_SYNC_ENGINE_GET_COMMIT_IDS_COMMAND_H_
6 #define CHROME_BROWSER_SYNC_ENGINE_GET_COMMIT_IDS_COMMAND_H_ 6 #define CHROME_BROWSER_SYNC_ENGINE_GET_COMMIT_IDS_COMMAND_H_
7 7
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 syncable::MetahandleSet inserted_metahandles_; 89 syncable::MetahandleSet inserted_metahandles_;
90 vector<syncable::Id> commit_ids_; 90 vector<syncable::Id> commit_ids_;
91 vector<int64> metahandle_order_; 91 vector<int64> metahandle_order_;
92 92
93 DISALLOW_COPY_AND_ASSIGN(OrderedCommitSet); 93 DISALLOW_COPY_AND_ASSIGN(OrderedCommitSet);
94 }; 94 };
95 95
96 96
97 // TODO(chron): Remove writes from this iterator. As a warning, this 97 // TODO(chron): Remove writes from this iterator. As a warning, this
98 // iterator causes writes to entries and so isn't a pure iterator. 98 // iterator causes writes to entries and so isn't a pure iterator.
99 // It will do Put(IS_UNSYNCED) as well as add things to the blocked 99 // It will do Put(IS_UNSYNCED). Refactor this out later.
100 // session list. Refactor this out later.
101 class CommitMetahandleIterator { 100 class CommitMetahandleIterator {
102 public: 101 public:
103 // TODO(chron): Cache ValidateCommitEntry responses across iterators to save 102 // TODO(chron): Cache ValidateCommitEntry responses across iterators to save
104 // UTF8 conversion and filename checking 103 // UTF8 conversion and filename checking
105 CommitMetahandleIterator(SyncerSession* session, 104 CommitMetahandleIterator(SyncerSession* session,
106 OrderedCommitSet* commit_set) 105 OrderedCommitSet* commit_set)
107 : session_(session), 106 : session_(session),
108 commit_set_(commit_set) { 107 commit_set_(commit_set) {
109 handle_iterator_ = session->unsynced_handles().begin(); 108 handle_iterator_ = session->unsynced_handles().begin();
110 109
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 OrderedCommitSet ordered_commit_set_; 190 OrderedCommitSet ordered_commit_set_;
192 191
193 int requested_commit_batch_size_; 192 int requested_commit_batch_size_;
194 193
195 DISALLOW_COPY_AND_ASSIGN(GetCommitIdsCommand); 194 DISALLOW_COPY_AND_ASSIGN(GetCommitIdsCommand);
196 }; 195 };
197 196
198 } // namespace browser_sync 197 } // namespace browser_sync
199 198
200 #endif // CHROME_BROWSER_SYNC_ENGINE_GET_COMMIT_IDS_COMMAND_H_ 199 #endif // CHROME_BROWSER_SYNC_ENGINE_GET_COMMIT_IDS_COMMAND_H_
OLDNEW
« no previous file with comments | « chrome/browser/sync/engine/conflict_resolver.cc ('k') | chrome/browser/sync/engine/process_commit_response_command.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698