Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10521)

Unified Diff: chrome_frame/test/perf/chrome_frame_perftest.cc

Issue 371025: More memory stats code cleanup:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: multiply uses by 1024 to keep stats consistent with old runs Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/process_util_win.cc ('K') | « chrome_frame/chrome_frame.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/perf/chrome_frame_perftest.cc
===================================================================
--- chrome_frame/test/perf/chrome_frame_perftest.cc (revision 31329)
+++ chrome_frame/test/perf/chrome_frame_perftest.cc (working copy)
@@ -23,7 +23,6 @@
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_paths_internal.h"
#include "chrome/test/chrome_process_util.h"
-#include "chrome/test/perf/mem_usage.h"
#include "chrome/test/ui/ui_test.h"
#include "chrome_frame/test_utils.h"
@@ -580,7 +579,7 @@
// Record the initial CommitCharge. This is a system-wide measurement,
// so if other applications are running, they can create variance in this
// test.
- start_commit_charge_ = GetSystemCommitCharge();
+ start_commit_charge_ = base::GetSystemCommitCharge();
for (int i = 0; i < total_urls; i++)
urls_.push_back(urls[i]);
@@ -690,8 +689,8 @@
// chrome processes which would have exited by now.
Sleep(200);
- size_t end_commit_charge = GetSystemCommitCharge();
- size_t commit_size = end_commit_charge - start_commit_charge_;
+ size_t end_commit_charge = base::GetSystemCommitCharge();
+ size_t commit_size = (end_commit_charge - start_commit_charge_) * 1024;
std::string trace_name(test_name);
trace_name.append("_cc");
@@ -764,7 +763,7 @@
ASSERT_FALSE(false);
}
- // Holds the commit charge at the start of the memory test run.
+ // Holds the commit charge in KBytes at the start of the memory test run.
size_t start_commit_charge_;
// The index of the URL being tested.
« base/process_util_win.cc ('K') | « chrome_frame/chrome_frame.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698