Move dev server to use cherrypy.

Move to using cherrypy.

This moves our devserver from using web to use cherrypy.
Cherrypy is more robust and provides byte range continuations than web.py.

Change-Id: I674f213a6c8c5de68e9ba78d3e97b682c016803f

BUG=7395
TEST=Ran with latest, forced, and archive_dir.  Tests for factory are ongoing.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7c93136

[anush, 2010-10-11 21:51:00]

At some point when we get a chance we should make dev-util an ebuild
installed in the chroot. It is important for us to be able to "upgrade"
developer chroots easily.

Thanks
Anush

On Mon, Oct 11, 2010 at 2:36 PM, <sosa@chromium.org> wrote:

> Reviewers: petkov, rtc,
>
> Description:
> Move to using cherrypy.
>
> This moves our devserver from using web to use cherrypy.
> Cherrypy is more robust and provides byte range continuations than web.py.
>
> Change-Id: I674f213a6c8c5de68e9ba78d3e97b682c016803f
>
> BUG=
> TEST=Ran with latest, forced, and archive_dir.  Tests for factory are
> ongoing.
>
> Please review this at http://codereview.chromium.org/3708004/show
>
> SVN Base: http://git.chromium.org/git/dev-util.git
>
> Affected files:
>  M autoupdate.py
>  M buildutil.py
>  M devserver.py
>
>
>

[sosa, 2010-10-11 21:51:37]

Agreed.  Is there an issue filed for this yet?

On Mon, Oct 11, 2010 at 2:50 PM, Anush Elangovan(அனுஷ்)
<anush@chromium.org> wrote:
> At some point when we get a chance we should make dev-util an ebuild
> installed in the chroot. It is important for us to be able to "upgrade"
> developer chroots easily.
>
> Thanks
> Anush
>
> On Mon, Oct 11, 2010 at 2:36 PM, <sosa@chromium.org> wrote:
>>
>> Reviewers: petkov, rtc,
>>
>> Description:
>> Move to using cherrypy.
>>
>> This moves our devserver from using web to use cherrypy.
>> Cherrypy is more robust and provides byte range continuations than web.py.
>>
>> Change-Id: I674f213a6c8c5de68e9ba78d3e97b682c016803f
>>
>> BUG=
>> TEST=Ran with latest, forced, and archive_dir.  Tests for factory are
>> ongoing.
>>
>> Please review this at http://codereview.chromium.org/3708004/show
>>
>> SVN Base: http://git.chromium.org/git/dev-util.git
>>
>> Affected files:
>>  M autoupdate.py
>>  M buildutil.py
>>  M devserver.py
>>
>>
>
>

[petkov, 2010-10-11 21:59:17]

Thanks for looking into this... A few nits/questions.

http://codereview.chromium.org/3708004/diff/6001/7001
File autoupdate.py (right):

http://codereview.chromium.org/3708004/diff/6001/7001#newcode39
autoupdate.py:39: self.hostname = '%s:%s' % (socket.gethostname(), port)
what happens if port is None here?

http://codereview.chromium.org/3708004/diff/6001/7001#newcode72
autoupdate.py:72: return latest_version.split(' - ')[0]
why spaces around -?

http://codereview.chromium.org/3708004/diff/6001/7004
File devserver.py (right):

http://codereview.chromium.org/3708004/diff/6001/7004#newcode41
devserver.py:41: base_config['global']['server.socket_port'] = int(options.port)
any reason why this is on a separate line?

[sosa, 2010-10-11 22:06:29]

Changed default and fixed version split.

PTAL

http://codereview.chromium.org/3708004/diff/6001/7001
File autoupdate.py (right):

http://codereview.chromium.org/3708004/diff/6001/7001#newcode39
autoupdate.py:39: self.hostname = '%s:%s' % (socket.gethostname(), port)
On 2010/10/11 21:59:17, petkov wrote:
> what happens if port is None here?
> 

Done.

http://codereview.chromium.org/3708004/diff/6001/7001#newcode72
autoupdate.py:72: return latest_version.split(' - ')[0]
On 2010/10/11 21:59:17, petkov wrote:
> why spaces around -?
> 

Done.

http://codereview.chromium.org/3708004/diff/6001/7004
File devserver.py (right):

http://codereview.chromium.org/3708004/diff/6001/7004#newcode41
devserver.py:41: base_config['global']['server.socket_port'] = int(options.port)
On 2010/10/11 21:59:17, petkov wrote:
> any reason why this is on a separate line?
> 

Done.

[petkov, 2010-10-11 22:14:32]

LGTM

[Nick Sanders, 2010-10-11 22:41:16]

lgtm, assuming factory install testing is ok

[anush, 2010-10-13 16:56:06]

On Mon, Oct 11, 2010 at 2:51 PM, Chris Sosa <sosa@chromium.org> wrote:

> Agreed.  Is there an issue filed for this yet?
>
>
Just filed 7703. It has you as the owner but feel free to reassign as
appropriate.

Thanks



> On Mon, Oct 11, 2010 at 2:50 PM, Anush Elangovan(அனுஷ்)
> <anush@chromium.org> wrote:
> > At some point when we get a chance we should make dev-util an ebuild
> > installed in the chroot. It is important for us to be able to "upgrade"
> > developer chroots easily.
> >
> > Thanks
> > Anush
> >
> > On Mon, Oct 11, 2010 at 2:36 PM, <sosa@chromium.org> wrote:
> >>
> >> Reviewers: petkov, rtc,
> >>
> >> Description:
> >> Move to using cherrypy.
> >>
> >> This moves our devserver from using web to use cherrypy.
> >> Cherrypy is more robust and provides byte range continuations than
> web.py.
> >>
> >> Change-Id: I674f213a6c8c5de68e9ba78d3e97b682c016803f
> >>
> >> BUG=
> >> TEST=Ran with latest, forced, and archive_dir.  Tests for factory are
> >> ongoing.
> >>
> >> Please review this at http://codereview.chromium.org/3708004/show
> >>
> >> SVN Base: http://git.chromium.org/git/dev-util.git
> >>
> >> Affected files:
> >>  M autoupdate.py
> >>  M buildutil.py
> >>  M devserver.py
> >>
> >>
> >
> >
>

[anush, 2010-10-13 16:56:12]

On Mon, Oct 11, 2010 at 2:51 PM, Chris Sosa <sosa@chromium.org> wrote:

> Agreed.  Is there an issue filed for this yet?
>
>
Just filed 7703. It has you as the owner but feel free to reassign as
appropriate.

Thanks



> On Mon, Oct 11, 2010 at 2:50 PM, Anush Elangovan(அனுஷ்)
> <anush@chromium.org> wrote:
> > At some point when we get a chance we should make dev-util an ebuild
> > installed in the chroot. It is important for us to be able to "upgrade"
> > developer chroots easily.
> >
> > Thanks
> > Anush
> >
> > On Mon, Oct 11, 2010 at 2:36 PM, <sosa@chromium.org> wrote:
> >>
> >> Reviewers: petkov, rtc,
> >>
> >> Description:
> >> Move to using cherrypy.
> >>
> >> This moves our devserver from using web to use cherrypy.
> >> Cherrypy is more robust and provides byte range continuations than
> web.py.
> >>
> >> Change-Id: I674f213a6c8c5de68e9ba78d3e97b682c016803f
> >>
> >> BUG=
> >> TEST=Ran with latest, forced, and archive_dir.  Tests for factory are
> >> ongoing.
> >>
> >> Please review this at http://codereview.chromium.org/3708004/show
> >>
> >> SVN Base: http://git.chromium.org/git/dev-util.git
> >>
> >> Affected files:
> >>  M autoupdate.py
> >>  M buildutil.py
> >>  M devserver.py
> >>
> >>
> >
> >
>