Issue 3707006: AU: Include the manifest size in the delta payload usage report.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3707006: AU: Include the manifest size in the delta payload usage report. (Closed)

Created:
10 years, 2 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

AU: Include the manifest size in the delta payload usage report. BUG=none TEST=generated delta reports Change-Id: I515953377757616ced2c2520396bab88e59b4474 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=95cf01f

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	delta_diff_generator.cc	View	1	4 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ suggestion http://codereview.chromium.org/3707006/diff/1/2 File delta_diff_generator.cc (right): http://codereview.chromium.org/3707006/diff/1/2#newcode1489 delta_diff_generator.cc:1489: ReportPayloadUsage(graph, manifest, serialized_manifest.size()); you might want ...

10 years, 2 months ago (2010-10-12 21:15:34 UTC) #2

petkov

10 years, 2 months ago (2010-10-12 21:58:58 UTC) #3

Done. Pushing...

http://codereview.chromium.org/3707006/diff/1/2
File delta_diff_generator.cc (right):

http://codereview.chromium.org/3707006/diff/1/2#newcode1489
delta_diff_generator.cc:1489: ReportPayloadUsage(graph, manifest,
serialized_manifest.size());
On 2010/10/12 21:15:34, adlr wrote:
> you might want to include the magic and other few bytes at the beginning, as
> long as you seem to be going for completeness.

Done.

Expand Messages | Collapse Messages