Issue 3706006: AU: Add a utility routine to get the filesystem size from a device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3706006: AU: Add a utility routine to get the filesystem size from a device. (Closed)

Created:
10 years, 2 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

AU: Add a utility routine to get the filesystem size from a device. BUG=7678 TEST=unit tests Change-Id: I177e95014e09c64844fa7ecc6efb91c0997cb9bd Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d3f8c89

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -1 line)			Patch
M	utils.h	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	utils.cc	View	1	2 chunks	+56 lines, -0 lines	0 comments	Download
M	utils_unittest.cc	View	1	2 chunks	+21 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ nit http://codereview.chromium.org/3706006/diff/1/3 File utils.h (right): http://codereview.chromium.org/3706006/diff/1/3#newcode118 utils.h:118: // Returns the block count and ...

10 years, 2 months ago (2010-10-13 00:19:12 UTC) #2

petkov

10 years, 2 months ago (2010-10-13 04:38:18 UTC) #3

Pushing...

http://codereview.chromium.org/3706006/diff/1/3
File utils.h (right):

http://codereview.chromium.org/3706006/diff/1/3#newcode118
utils.h:118: // Returns the block count and byte size of the ext3 file system on
|device| or
On 2010/10/13 00:19:12, adlr wrote:
> ...on |device| (which may be a real device or a path to a filesystem image)
> or...

Done.

Expand Messages | Collapse Messages